Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes 10/5/2024 #73

Merged
merged 12 commits into from
Oct 5, 2024
Merged

Hotfixes 10/5/2024 #73

merged 12 commits into from
Oct 5, 2024

Conversation

VMSolidus
Copy link
Contributor

This update includes several hotfixes for issues found during today's playtesting.

Mnemotechnician and others added 12 commits October 5, 2024 10:28
# Description
How did this pass code review?

# Media
<details>


![image](https://github.com/user-attachments/assets/1161cc1e-3f61-4b2d-95e1-ab120fd3a1e1)


![image](https://github.com/user-attachments/assets/3bc1c945-98db-403e-94b1-351d13574aaf)

</details>

# Changelog
N/A

---------

Signed-off-by: Mnemotechnican <[email protected]>
Co-authored-by: stellar-novas <[email protected]>
# Description
Makes natural blood regeneration use up some hunger and thirst, and halt
completely when you are starving/dying of thirst.

This is necessary to fix two issues:
1. It being possible to feed off of your own blood, by repeatedly
drawing your blood and injecting it back with a syringe. (I actually
know a few people on floof who do that on a daily basis)
2. Hunger and thirst having no real impact on gameplay, besides giving
you a mildly annoying depression overlay when low.

This PR also slightly refactors the blood deficiency trait so that it's
no longer completely hardcoded in the bloodstream system.

<details><summary><h1>Media</h1></summary>
<p>


https://github.com/user-attachments/assets/f8634de5-19bd-44a5-ada2-62f4504bf3d4

</p>
</details>

# Changelog
:cl:
- add: Blood regeneration now uses up hunger and thirst, and comes to a
halt when you are very hungry or thirst.
- fix: It is no longer feasible to drink your own blood to satiate your
own hunger.
# Description

This PR updates the Localizations relevant to the Reptilian species by
significantly expanding upon them as Unathi, which is how they are
typically referred to as in both /tg/station and Baystation12 derived
codebases in SS13. I have added a new "Rare" language taken from Aurora,
called Azaziba, which can only be taken by Unathi as a bonus language
trait.

Translators for this new language Azaziba are intentionally not
obtainable ingame except as spawned by Admins. This is a "Rare"
language, and shouldn't be accessible to players outside of Unathi
obtaining the trait.

The biggest change in this update however is a massive expansion upon
the Unathi Guidebook entry, providing a significant volume of Lore,
which is largely taken(with slight modifications) from
https://wiki.aurorastation.org/index.php?title=Unathi (Which, I can do
this since their wiki has a Creative Commons license). This is probably
the best way to get good quality lore for them, other than by writing it
myself.

<details><summary><h1>Media</h1></summary>
<p>


![image](https://github.com/user-attachments/assets/842d9c40-3cf3-41ab-a9fe-f0aac81c1bce)


![image](https://github.com/user-attachments/assets/f1ef8090-97a4-46f9-8548-9389606d4e3b)


![image](https://github.com/user-attachments/assets/870ab41c-fe00-45cf-8440-51cfe3f0b164)


![image](https://github.com/user-attachments/assets/09a8548a-cb98-4158-b0a8-e641078ecf80)

</p>
</details>

# Changelog

:cl:
- add: Localizations for Reptilians that acknowledge them now as Unathi.
- add: Azaziba has been added as a new "Rare" language that can only be
taken by Unathi. Translators between Azaziba and Tau-Ceti Basic do not
exist, please do not make them.
- add: SIGNIFICANTLY expanded upon the Guidebook for Unathi by including
a large volume of lore taken from the Aurora Station Wiki.
# Description

Fixes a bug with CloningSystem. It now correctly spills blood upon
cloning fail.

# Changelog

:cl:
- fix: Fixed a bug with CloningSystem. It now correctly spills blood
upon cloning fail.
# Description

This PR adds a CVar that allows server hosts (such as N14 who need it)
to optionally disable the Crit Threshold modification part of the
MoodSystem. This is useful if a server has some other system that
frequently messes with Thresholds, and that a server host wishes their
system to not have to fight with Mood for it.

# Changelog

No changelog because this isn't playerfacing.
@VMSolidus VMSolidus merged commit b425262 into master Oct 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants